[Carpet] CCTK_TraverseString: invalid group/variable name

[Thomas Radke]

Luca Baiotti wrote:
> Indeed I wrote what above as a counterexample to setting level 1 
> warnings to be lethal ;-) I do want to see the above warning, but - of 
> course - I don't want it to be lethal. Did I explain clearly this time?

You did, yes. My mistake, sorry !

> I do not see the level 0 warning and I do not set the parameter you 
> mention. This means that probably there is a bug in the output routines. 
> Check yourself my data on belladonna in 
> /data21/baiotti/prova_recovery-parameters. The parfile is 
> check_recovery-parameters.par and the stderr/out is provaREecovParam.o12867
> 
> I would really like IOUtil etc. to behave like you said and stop the run.

Me too :-) So thanks for the provided information !

I recreated a configuration from your parfile and ran it, with the same 
effect: no abort on parameter checking errors. Debugging the run 
revealed a problem in the CCTK_TraverseString() parser routine 
(congratulations, you found a flesh bug!).
I fixed it; after updating src/main/Groups.c you should now also see 
your simulation aborting with something like:

> WARNING level 1 in thorn Cactus processor 0 host node0047.admin
>   (line 2279 of /data1/tradke/cactus/configs/luca/build/Cactus/main/Groups.c): 
>   -> CCTK_TraverseString: invalid group/variable name 'ADMMass::ADMMass_Massess' in traversed string '
>                                           carpetregrid2::positions
>                                           Whisky::whisky_maxima_separation
>                                           Carpet::timing
>                                           Carpet::timing2
>                                           whisky_analysis::whisky_total_angular_momentum                                          
>                                           whisky_analysis::whisky_angular_momentum_z
>                                           whisky_analysis::whisky_total_rest_mass
>                                           ADMMass::ADMMass_Massess
>                                           CCCCAnalysis::rest_mass
>                                           CCCCAnalysis::proper_mass
>                                           CCCCAnalysis::gravitational_mass
>                                           CCCCAnalysis::angular_momentum
>                                           CCCCAnalysis::kinetic_energy
>                                           CCCCAnalysis::adm_mass
>                                           '
> WARNING level 0 in thorn IOUtil processor 0 host node0047.admin
>   (line 132 of /data1/tradke/cactus/configs/luca/build/IOUtil/Utils.c): 
>   -> error while parsing parameter 'IOASCII::out0D_vars'
> WARNING level 0 in thorn IOUtil processor 0 host node0047.admin
>   (line 132 of /data1/tradke/cactus/configs/luca/build/IOUtil/Utils.c): 
>   -> error while parsing parameter 'IOASCII::out0D_vars'
> cactus_luca: /data1/tradke/cactus/configs/luca/build/Carpet/helpers.cc:150: Assertion `0' failed.
> mpiexec: Warning: task 0 died with signal 6 (Aborted).

-- 
Cheers, Thomas.