[Carpet] commit 1dd96e20cb7a87d294c5298b46f01dff97b0da53 broke testsuites

[Baiotti Luca]

Erik,

> This patch corrects an error in the interaction between MoL and Carpet's 
> recursive initialisation.  For example, the ADM variables are converted 
> to the BSSN variables, and the BSSN variables then need to have their 
> boundary conditions applied before the recursive initialisation of the 
> finer grids, so that finer grids can have their mesh refinement 
> boundaries interpolated from coarser grids.
> 
> This patch corrects an inconsistency.  In some cases some variables were 
> not initialised or were initialised differently than they should have 
> been.  I found this while setting up a new benchmark that uses Whisky.  
> I'm sure I set up my parameter file different than others (it wasn't 
> using BSSN_MoL), but the inconsistency was real: MoL_PostStep was 
> scheduled after the recursive initialisation, which is wrong.  I expect 
> that most codes contain ad-hoc work-arounds for this inconsistency, e.g. 
> by scheduling or applying boundary conditions explicitly in the INITIAL 
> bin.
> 
> I checked Whisky, and I thought it was fine except for Whisky_TOVSolverC 
> which I updated.
> 
> Which test case is breaking?  I see for example 
> whisky_test_Carpet-3levels_RotNS failing for the velocities and the 
> Hamiltonian constraint.  The velocities are identical at t=0, only small 
> differences develop at later times -- I do not know whether they are 
> significant.

Actually that testsuite is failing, with visible, big differences.

> I think that Whisky is not included in the automated build tests on 
> portal.aei.mpg.de.  Should we include it?

Actually whisky is already included and three of the testsuites are 
shown to fail, on the portal (but in a private portal, as Thomas said).

I wonder how it can pass for you?


Luca