[Carpet] [Carpet-darcs] CarpetEvolutionMask: fix 2D output for CarpetEvolutionMask_test testsuite

[Erik Schnetter]

On Jan 26, 2007, at 06:42:22, Thomas Radke wrote:

> Erik Schnetter wrote:
>> On Dec 20, 2006, at 04:59:27, Carpet-Repository wrote:
>>
>>> The Carpet repository at ~darcs/carpet received a new patch:
>>>
>>>    CarpetEvolutionMask: fix 2D output for CarpetEvolutionMask_test
>>> testsuite
>>>
>>> This patch was recorded by Thomas Radke <tradke at aei.mpg.de> at
>>> 2006-12-19 20:58:34.
>>>
>>> The long comment for this patch reads:
>>>
>>>  All it took was to change IO::out_fileinfo="none" into
>>> IO::out_fileinfo="axis labels".
>>
>>
>> This test case does not pass for me.  The repository contains *.xg
>> files for the norms, which is very strange for CarpetIOScalar output;
>> there should be *.asc files.
>>
>> Thomas, can you check this test case again?
>
> I did, and it turns out that I made a mistake there being inconsistent
> in fixing this testsuite (sorry about that).
>
> One problem was that the 1D/2D CarpetIOASCII files contain header
> information which is produced only with IO::out_fileinfo = "axis
> labels". That I fixed with this patch.
> However, another problem still remained: the testsuite still contains
> the norms from CactusBase/IOBasic which are not compatible with
> CarpetIOScalar output. When creating the patch I had switched back to
> using thorn IOBasic (in its old version from before 1 Nov 2005 which
> doesn't use the new reduction API yet) in the testsuite parfile. The
> testsuite would now succeed for all the norms but only with
> IO::out_fileinfo still set to "none" as before.
>
> Anyway, I believe the testsuite is still passing in principle. One  
> only
> needs to fix the header information in the 1D/2D ASCII output files  
> and
> recreate the norms in CarpetIOScalar format. Would you agree ? If  
> so I'd
> create another patch.

Yes, I agree.  Thank you!

-erik

-- 
Erik Schnetter <schnetter at cct.lsu.edu>

My email is as private as my paper mail.  I therefore support encrypting
and signing email messages.  Get my PGP key from www.keyserver.net.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : /archives/developers/attachments/20070126/19c750e7/attachment.pgp