[Carpet] inconsistent mask scheduling

[Bela Szilagyi]

I believe that the scheduling of mask-related functions in 

CactusEinstein/SpaceMask 

is inconsistent with the ones in 

AEIThorns/AHFinderDirect.

Take, e.g., the items


schedule AHFinderDirect_maybe_do_masks at CCTK_POSTREGRID \
   after (MaskOne MaskZero)
         {
         lang: C
         options: global loop-local
         } "set mask(s) based on apparent horizon position(s)"


and, correspondingly

  schedule MaskOne at CCTK_BASEGRID
  {
    LANG: C
  } "Set old style mask to one"

  schedule MaskZero at CCTK_BASEGRID
  {
    LANG: C
  } "Initialise mask to zero"

which have no "global loop-local" spec.  By implication, as I understand, the 
SpaceMask routines will not necessarily follow before the AHFinderDirect 
routines.

There is a similar issue with the mask-checker routine of SpaceMask, with no 
scheduling options, while one would expect it should go after the 
AHFinderDirect routine.

One can argue that this is an issue with AHFinderDirect rather than 
CactusBase, or with Carpet.  But this argument would not bring the issue any 
further, so I will make no point to it.

Please, take a look, fix it,and let the "user" know the solution, as defined.  
Other thorns correct functioning may depend on this inconsistency.


Bela.


-- 
Bela Szilagyi

Max-Planck-Institut für Gravitationsphysik
Albert-Einstein-Institut
Tel: +49 331 567 7632
Fax: +49 331 567 7649