[Carpet] CarpetIOHDF5 testsuites are broken

[Erik Schnetter]

On Sep 4, 2006, at 09:25:37, Luca Baiotti wrote:

> Hi,
>
> I have investigated further the CarpetIOHDF5 testsuite problem.
>
> I have found out that, removing all recent patsches (in darcs) back to
>
> Tue May  9 15:06:37 CEST 2006  Erik Schnetter <schnetter at cct.lsu.edu>
>    * Carpet: Add aliased function QueryProlongating()
>
> (included in the unpull) and going back to the corrispondent cvs  
> version
> of cactus, the testsuite passes (I am referring to the
> Carpet/CarpetIOHDF5/test/CarpetWaveToyRecover_test_1proc.par  
> testsuite).
>
> After applying the above patch the testsuite fails. The data (e.g.
> phi.x.asc) differ at the initial time (after recovery) of as much as
> 0.1% and are visible to the eye in ygraph without zooming.
>
> The data produced by running the testsuite with all the patches up to
> the one above included and the data produced with all the patches  
> (up to
> today) coincide; (i.e. there have been no more changes in the results
> produced by running the testuite from the above patch up to now;  
> and the
> testsuite data in the repository have not been changed since Feb  
> 6th 2006.
>
> Can someone more expert than I further investigate why the above patch
> broke the testuite? And commit a fix?

Hi Luca,

thanks a lot for tracking this down.

The patch itself is really harmless -- it adds a single function  
which does not modify anything.  It adds nine lines of code, and they  
look perfectly harmless.

I first thought that the real cause is that there is another thorn  
which changes its behaviour depending on whether this function is  
present, but this function is unused.  (I introduced it for Béla who  
wanted to experiment with prolongation for excision boundaries.)

Since the function is unused, you can take the current version of  
Carpet an unpull only this patch.  When I do that, the test case  
still fails.

-erik

-- 
Erik Schnetter <schnetter at cct.lsu.edu>

My email is as private as my paper mail.  I therefore support encrypting
and signing email messages.  Get my PGP key from www.keyserver.net.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : /archives/developers/attachments/20060904/cada8018/attachment.pgp