[Carpet] Error when recovering from a checkpoint file

[Thomas Radke]

Erik Schnetter wrote:
> The routine IOUtil_GetAllParameters encodes all parameters into a  
> single string.  I think it should encode strings differently.  It  
> appears that the output of this routine is supposed to be human  
> readable.  In this case, it could e.g. enclose strings in quotes and  
> escape quotes and non-printable characters according to the rules for  C 
> strings.  The routine IOUtil_SetAllParameters would then need to  parse 
> these strings.  (Just to be safe, it could also check whether  the 
> assignment symbol "=" is really present.)

This was clearly a bug in the checkpoint/recovery code. I fixed it so 
that non-printable characters (including newlines) in parameter values 
are now safely handled.

As to what should be done about the inconsistent treatment of parameter 
values (the parameter file parser eats newlines whereas 
CCTK_ParameterSet preserves them), I have no clear opinion.

I'll raise the question as a separate thread on the Cactus users list.

-- 
Cheers, Thomas.